netdev - Re: [PATCH] net: ena: Do not waste napi skb cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bad34ba9-eacf-f325-7ebc-6fdd43414945@gmail.com>
Date:   Tue, 25 Jan 2022 15:50:30 +0200
From:   Julian Wiedmann <jwiedmann.dev@...il.com>
To:     Hyeonggon Yoo <42.hyeyoo@...il.com>,
        Shay Agroskin <shayagr@...zon.com>
Cc:     netdev@...r.kernel.org, Arthur Kiyanovski <akiyano@...zon.com>,
        David Arinzon <darinzon@...zon.com>,
        Noam Dagan <ndagan@...zon.com>,
        Saeed Bishara <saeedb@...zon.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ena: Do not waste napi skb cache

On 25.01.22 11:34, Hyeonggon Yoo wrote:
> On Mon, Jan 24, 2022 at 10:50:05PM +0200, Shay Agroskin wrote:
>>

[...]

>>
>> I agree that the netdev_alloc_skb_ip_align() can become napi_alloc_skb().
>> Hyeonggon Yoo, can you please apply this change as well to this patch?
>>
> 
> Okay. I'll update and test it again.
> 
> BTW, It seems netdev_alloc_skb_ip_align() is used to make some fields
> be aligned. It's okay to just ignore this?
> 

napi_alloc_skb() adds NET_IP_ALIGN internally, so you end up with the same alignment as before.


> Thanks,
> Hyeonggon.
> 
>> Thanks,
>> Shay
>>
>>
>>>>>  	else
>>>>> -		skb = build_skb(first_frag, ENA_PAGE_SIZE);
>>>>> +		skb = napi_build_skb(first_frag, ENA_PAGE_SIZE);
>>>>>  	if (unlikely(!skb)) {
>>>>>  		ena_increase_stat(&rx_ring->rx_stats.skb_alloc_fail,  1,
>>>>