netdev - Re: [PATCH net-next v2 2/2] net: dsa: microchip: Add property to disable reference clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YfA0Ov8Skh0e50uA@lunn.ch>
Date:   Tue, 25 Jan 2022 18:32:42 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Robert Hancock <robert.hancock@...ian.com>
Cc:     netdev@...r.kernel.org, woojung.huh@...rochip.com,
        UNGLinuxDriver@...rochip.com, vivien.didelot@...il.com,
        f.fainelli@...il.com, olteanv@...il.com, davem@...emloft.net,
        kuba@...nel.org, robh+dt@...nel.org, marex@...x.de,
        devicetree@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net: dsa: microchip: Add property to
 disable reference clock

>  		dev->synclko_125 = of_property_read_bool(dev->dev->of_node,
>  							 "microchip,synclko-125");
> +		dev->synclko_disable = of_property_read_bool(dev->dev->of_node,
> +							     "microchip,synclko-disable");

It seems like microchip,synclko-125 and microchip,synclko-disable are
mutually exclusive? Please add an -EINVAL if both a present.

This should also be mentioned in the binding document.

Thanks
	Andrew