netdev - Re: [PATCH net-next] gve: Fix GFP flags when allocing pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220125153637.7bd81c37@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 25 Jan 2022 15:36:37 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     David Awogbemila <awogbemila@...gle.com>
Cc:     netdev@...r.kernel.org, jeroendb@...gle.com,
        Catherine Sullivan <csully@...gle.com>
Subject: Re: [PATCH net-next] gve: Fix GFP flags when allocing pages

On Tue, 25 Jan 2022 13:59:10 -0800 David Awogbemila wrote:
> From: Catherine Sullivan <csully@...gle.com>
> 
> Use GFP_ATOMIC when allocating pages out of the hotpath,
> continue to use GFP_KERNEL when allocating pages during setup.
> 
> GFP_KERNEL will allow blocking which allows it to succeed
> more often in a low memory enviornment but in the hotpath we do
> not want to allow the allocation to block.

Sounds like a fix, right?  Sleeping in atomic is a bug.
In that case please resend as [PATCH net] and with a Fixes: tag
included.

FWIW adding cover letters with a single patch is not required,
but you can keep it if you prefer it that way.