netdev - [PATCH net] sch_cake: diffserv8 CS1 should be bulk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Jan 2022 14:04:10 +0800
From:   Matt Johnston <matt@...econstruct.com.au>
To:     unlisted-recipients:; (no To-header on input)
Cc:     Kevin Darbyshire-Bryant <ldir@...byshire-bryant.me.uk>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        cake@...ts.bufferbloat.net
Subject: [PATCH net] sch_cake: diffserv8 CS1 should be bulk

The CS1 priority (index 0x08) was changed from 0 to 1 when LE (index
0x01) was added. This looks unintentional, it doesn't match the
docs and CS1 shouldn't be the same tin as AF1x

Signed-off-by: Matt Johnston <matt@...econstruct.com.au>
Fixes: b8392808eb3f ("sch_cake: add RFC 8622 LE PHB support to CAKE diffserv handling")
---
 net/sched/sch_cake.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c
index 857aaebd49f4..6ff2ddc5b812 100644
--- a/net/sched/sch_cake.c
+++ b/net/sched/sch_cake.c
@@ -313,7 +313,7 @@ static const u8 precedence[] = {
 
 static const u8 diffserv8[] = {
 	2, 0, 1, 2, 4, 2, 2, 2,
-	1, 2, 1, 2, 1, 2, 1, 2,
+	0, 2, 1, 2, 1, 2, 1, 2,
 	5, 2, 4, 2, 4, 2, 4, 2,
 	3, 2, 3, 2, 3, 2, 3, 2,
 	6, 2, 3, 2, 3, 2, 3, 2,
-- 
2.32.0