netdev - Re: [PATCH iproute2-next v1] tc: add skip_hw and skip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <450375bd-6985-202c-7ad2-c11c97fe5b0c@mojatatu.com>
Date:   Wed, 26 Jan 2022 06:57:32 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Baowen Zheng <baowen.zheng@...igine.com>,
        Victor Nogueira <victor@...atatu.com>
Cc:     David Ahern <dsahern@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        oss-drivers <oss-drivers@...igine.com>,
        Simon Horman <simon.horman@...igine.com>
Subject: Re: [PATCH iproute2-next v1] tc: add skip_hw and skip_sw to control
 action offload

Hi Baowen,
I didnt follow what "next patch" means because just prior to this
email you sent a v2.

As a general rule:
You have to run the tdc tests and if your iproute2 patch is breaking
something that was working fine before your patch then it needs to be
fixed first. Perhaps thats what you meant is your v2 fixes the vlan
breakage.

cheers,
jamal

On 2022-01-26 03:14, Baowen Zheng wrote:
> Hi Victor, thanks very much to bring this issue to us, we will make a check and fix this issue in next patch.
> 
> On Tuesday, January 25, 2022 11:23 PM, Victor wrote:
>> Hi Baowen,
>>
>> I applied your patch, ran tdc.sh and in particular the vlan tests broke.
>>
>> cheers,
>> Victor