lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Jan 2022 10:43:42 +0800 From: Menglong Dong <menglong8.dong@...il.com> To: David Ahern <dsahern@...il.com> Cc: Jakub Kicinski <kuba@...nel.org>, Steven Rostedt <rostedt@...dmis.org>, mingo@...hat.com, David Miller <davem@...emloft.net>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, David Ahern <dsahern@...nel.org>, pablo@...filter.org, kadlec@...filter.org, Florian Westphal <fw@...len.de>, Menglong Dong <imagedong@...cent.com>, Eric Dumazet <edumazet@...gle.com>, alobakin@...me, paulb@...dia.com, Paolo Abeni <pabeni@...hat.com>, talalahmad@...gle.com, haokexin@...il.com, Kees Cook <keescook@...omium.org>, memxor@...il.com, LKML <linux-kernel@...r.kernel.org>, netdev <netdev@...r.kernel.org>, netfilter-devel@...r.kernel.org, coreteam@...filter.org, Cong Wang <cong.wang@...edance.com> Subject: Re: [PATCH net-next 5/6] net: udp: use kfree_skb_reason() in udp_queue_rcv_one_skb() On Wed, Jan 26, 2022 at 10:25 AM David Ahern <dsahern@...il.com> wrote: > > On 1/24/22 6:15 AM, menglong8.dong@...il.com wrote: > > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > > index 603f77ef2170..dd64a4f2ff1d 100644 > > --- a/include/linux/skbuff.h > > +++ b/include/linux/skbuff.h > > @@ -330,6 +330,7 @@ enum skb_drop_reason { > > SKB_DROP_REASON_UNICAST_IN_L2_MULTICAST, > > SKB_DROP_REASON_XFRM_POLICY, > > SKB_DROP_REASON_IP_NOPROTO, > > + SKB_DROP_REASON_UDP_FILTER, > > Is there really a need for a UDP and TCP version? why not just: > > /* dropped due to bpf filter on socket */ > SKB_DROP_REASON_SOCKET_FILTER > I realized it, but SKB_DROP_REASON_TCP_FILTER was already introduced before. Besides, I think maybe a SKB_DROP_REASON_L4_CSUM is enough for UDP/TCP/ICMP checksum error? > > SKB_DROP_REASON_MAX, > > }; > > >
Powered by blists - more mailing lists