lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Jan 2022 11:13:35 +0800 From: Menglong Dong <menglong8.dong@...il.com> To: David Ahern <dsahern@...il.com> Cc: Jakub Kicinski <kuba@...nel.org>, Steven Rostedt <rostedt@...dmis.org>, mingo@...hat.com, David Miller <davem@...emloft.net>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, David Ahern <dsahern@...nel.org>, pablo@...filter.org, kadlec@...filter.org, Florian Westphal <fw@...len.de>, Menglong Dong <imagedong@...cent.com>, Eric Dumazet <edumazet@...gle.com>, alobakin@...me, paulb@...dia.com, Paolo Abeni <pabeni@...hat.com>, talalahmad@...gle.com, haokexin@...il.com, Kees Cook <keescook@...omium.org>, memxor@...il.com, LKML <linux-kernel@...r.kernel.org>, netdev <netdev@...r.kernel.org>, netfilter-devel@...r.kernel.org, coreteam@...filter.org, Cong Wang <cong.wang@...edance.com> Subject: Re: [PATCH net-next 3/6] net: ipv4: use kfree_skb_reason() in ip_rcv_finish_core() On Wed, Jan 26, 2022 at 10:57 AM David Ahern <dsahern@...il.com> wrote: > > On 1/25/22 7:36 PM, Menglong Dong wrote: > > Is't it meaningful? I name it from the meaning of 'ip route lookup or validate > > failed in input path', can't it express this information? > > > ip_route_input_noref has many failures and not all of them are FIB > lookups. ip_route_input_slow has a bunch of EINVAL cases for example. > > Returning a 'reason' as the code function name has no meaning to a user > and could actually be misleading in some cases. I would skip this one > for now. Yeah, the real reason can be complex. I'll skip this case for now.
Powered by blists - more mailing lists