netdev - [PATCH net-next 5/6] net: page_pool: Add stat tracking cache refills.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1643237300-44904-6-git-send-email-jdamato@fastly.com>
Date:   Wed, 26 Jan 2022 14:48:19 -0800
From:   Joe Damato <jdamato@...tly.com>
To:     netdev@...r.kernel.org
Cc:     kuba@...nel.org, davem@...emloft.net, ilias.apalodimas@...aro.org,
        hawk@...nel.org, Joe Damato <jdamato@...tly.com>
Subject: [PATCH net-next 5/6] net: page_pool: Add stat tracking cache refills.

Add a stat tracking succesfull allocations which triggered a refill. A
static inline wrapper is exposed for accessing this stat.

Signed-off-by: Joe Damato <jdamato@...tly.com>
---
 include/net/page_pool.h | 11 ++++++++++-
 net/core/page_pool.c    |  2 ++
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/include/net/page_pool.h b/include/net/page_pool.h
index 92edf8e..a68d05f 100644
--- a/include/net/page_pool.h
+++ b/include/net/page_pool.h
@@ -87,7 +87,7 @@ struct page_pool_stats {
 		u64 empty; /* failed refills due to empty ptr ring, forcing
 			    * slow path allocation
 			    */
-
+		u64 refill; /* allocations via successful refill */
 	} alloc;
 };
 
@@ -222,6 +222,10 @@ static inline u64 page_pool_stats_get_empty(struct page_pool *pool)
 	return pool->ps.alloc.empty;
 }
 
+static inline u64 page_pool_stats_get_refill(struct page_pool *pool)
+{
+	return pool->ps.alloc.refill;
+}
 #else
 static inline void page_pool_destroy(struct page_pool *pool)
 {
@@ -261,6 +265,11 @@ static inline u64 page_pool_stats_get_empty(struct page_pool *pool)
 {
 	return 0;
 }
+
+static inline u64 page_pool_stats_get_refill(struct page_pool *pool)
+{
+	return 0;
+}
 #endif
 
 void page_pool_put_page(struct page_pool *pool, struct page *page,
diff --git a/net/core/page_pool.c b/net/core/page_pool.c
index 0de9d58..15f4e73 100644
--- a/net/core/page_pool.c
+++ b/net/core/page_pool.c
@@ -171,6 +171,8 @@ static struct page *__page_pool_get_cached(struct page_pool *pool)
 		pool->ps.alloc.fast++;
 	} else {
 		page = page_pool_refill_alloc_cache(pool);
+		if (likely(page))
+			pool->ps.alloc.refill++;
 	}
 
 	return page;
-- 
2.7.4