netdev - Re: [wpan v3 1/6] net: ieee802154: hwsim: Ensure proper channel selection at probe time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <344c7192-20b6-15f5-021c-092148f87bca@datenfreihafen.org>
Date:   Thu, 27 Jan 2022 08:33:15 +0100
From:   Stefan Schmidt <stefan@...enfreihafen.org>
To:     Alexander Aring <alex.aring@...il.com>
Cc:     Miquel Raynal <miquel.raynal@...tlin.com>,
        linux-wpan - ML <linux-wpan@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
        David Girault <david.girault@...vo.com>,
        Romuald Despres <romuald.despres@...vo.com>,
        Frederic Blain <frederic.blain@...vo.com>,
        Nicolas Schodet <nico@...fr.eu.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [wpan v3 1/6] net: ieee802154: hwsim: Ensure proper channel
 selection at probe time

Hello.

On 26.01.22 23:54, Alexander Aring wrote:
> Hi,
> 
> On Wed, Jan 26, 2022 at 8:38 AM Stefan Schmidt
> <stefan@...enfreihafen.org> wrote:
>>
>>
>> Hello.
>>
>> On 25.01.22 17:48, Miquel Raynal wrote:
>>> Hi Stefan,
>>>
>>> stefan@...enfreihafen.org wrote on Tue, 25 Jan 2022 15:28:11 +0100:
>>>
>>>> Hello.
>>>>
>>>> On 25.01.22 13:14, Miquel Raynal wrote:
>>>>> Drivers are expected to set the PHY current_channel and current_page
>>>>> according to their default state. The hwsim driver is advertising being
>>>>> configured on channel 13 by default but that is not reflected in its own
>>>>> internal pib structure. In order to ensure that this driver consider the
>>>>> current channel as being 13 internally, we at least need to set the
>>>>> pib->channel field to 13.
>>>>>
>>>>> Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb")
>>>>> Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
>>>>> ---
>>>>>     drivers/net/ieee802154/mac802154_hwsim.c | 1 +
>>>>>     1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c
>>>>> index 8caa61ec718f..00ec188a3257 100644
>>>>> --- a/drivers/net/ieee802154/mac802154_hwsim.c
>>>>> +++ b/drivers/net/ieee802154/mac802154_hwsim.c
>>>>> @@ -786,6 +786,7 @@ static int hwsim_add_one(struct genl_info *info, struct device *dev,
>>>>>              goto err_pib;
>>>>>      }
>>>>>     > +      pib->page = 13;
>>>>
>>>> You want to set channel not page here.
>>>
>>> Oh crap /o\ I've messed that update badly. Of course I meant
>>> pib->channel here, as it is in the commit log.
>>>
>>> I'll wait for Alexander's feedback before re-spinning. Unless the rest
>>> looks good for you both, I don't know if your policy allows you to fix
>>> it when applying, anyhow I'll do what is necessary.
>>
>> If Alex has nothing else and there is no re-spin I fix this when
>> applying, no worries.
> 
> Everything is fine.
> 
> Acked-by: Alexander Aring <aahringo@...hat.com>
> 
> On the whole series. Thanks.

Fixed up this commit and applied the whole patchset.

Next one we should look at would be the 3 split out cleanup patches.

regards
Stefan Schmidt