netdev - RE: [PATCH 1/3 v3] net: usb: r8152: Check used MAC passthrough address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe97d50054484f4f8299bc340166a625@realtek.com>
Date:   Thu, 27 Jan 2022 08:42:57 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Aaron Ma <aaron.ma@...onical.com>,
        "Limonciello, Mario" <Mario.Limonciello@....com>,
        Henning Schild <henning.schild@...mens.com>
CC:     Jakub Kicinski <kuba@...nel.org>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Andrew Lunn <andrew@...n.ch>, Oliver Neukum <oneukum@...e.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "tiwai@...e.de" <tiwai@...e.de>
Subject: RE: [PATCH 1/3 v3] net: usb: r8152: Check used MAC passthrough address

Aaron Ma <aaron.ma@...onical.com>
> Sent: Thursday, January 27, 2022 4:13 PM
[...]
> > I don't think the feature of MAC passthrough address is maintained
> > by Realtek. Especially, there is no uniform way about it. The
> > different companies have to maintain their own ways by themselves.
> >
> > Realtek could provide the method of finding out the specific device
> > for Lenovo. You could check USB OCP 0xD81F bit 3. For example,
> >
> > 	ocp_data = ocp_read_byte(tp, MCU_TYPE_USB, USB_MISC_1);
> > 	if (tp->version == RTL_VER_09 && (ocp_data & BIT(3))) {
> > 		/* This is the RTL8153B for Lenovo. */
> > 	}
> >
> 
> May I use the code from Realtek Outbox driver to implement the MAPT?
> 
> If so, allow me to write a patch and send here to review.

Sure.

However, the outbox driver has a mistake.
The mac_obj_name with "\\_SB.AMAC" is used by Dell.
I think the device of Lenovo should use "\\MACA" only. Right?

The easiest way is to set tp->lenovo_macpassthru for RTL8153BL.
For example,

	ocp_data = ocp_read_byte(tp, MCU_TYPE_USB, USB_MISC_1);
	if (tp->version == RTL_VER_09 && (ocp_data & BIT(3)))
		tp->lenovo_macpassthru = 1;

Best Regards,
Hayes