netdev - Re: [RFCv2 net-next 000/167] net: extend the netdev_features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f49d8f3f-f9e9-574f-f41b-01d35a0a1b03@huawei.com>
Date:   Thu, 27 Jan 2022 17:40:02 +0800
From:   "shenjian (K)" <shenjian15@...wei.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <andrew@...n.ch>,
        <hkallweit1@...il.com>, <netdev@...r.kernel.org>,
        <linuxarm@...neuler.org>
Subject: Re: [RFCv2 net-next 000/167] net: extend the netdev_features_t



在 2022/1/27 17:16, Leon Romanovsky 写道:
> On Wed, Sep 29, 2021 at 11:50:47PM +0800, Jian Shen wrote:
>> For the prototype of netdev_features_t is u64, and the number
>> of netdevice feature bits is 64 now. So there is no space to
>> introduce new feature bit.
>>
>> This patchset try to solve it by change the prototype of
>> netdev_features_t from u64 to bitmap. With this change,
>> it's necessary to introduce a set of bitmap operation helpers
>> for netdev features. Meanwhile, the functions which use
>> netdev_features_t as return value are also need to be changed,
>> return the result as an output parameter.
>>
>> With above changes, it will affect hundreds of files, and all the
>> nic drivers. To make it easy to be reviewed, split the changes
>> to 167 patches to 5 parts.
>>
>> patch 1~22: convert the prototype which use netdev_features_t
>> as return value
>> patch 24: introduce fake helpers for bitmap operation
>> patch 25~165: use netdev_feature_xxx helpers
>> patch 166: use macro __DECLARE_NETDEV_FEATURE_MASK to replace
>> netdev_feature_t declaration.
>> patch 167: change the type of netdev_features_t to bitmap,
>> and rewrite the bitmap helpers.
>>
>> Sorry to send a so huge patchset, I wanna to get more suggestions
>> to finish this work, to make it much more reviewable and feasible.
>>
>> The former discussing for the changes, see [1]
>> [1]. https://www.spinics.net/lists/netdev/msg753528.html
>>
> ------------------------------------------------
>
> Is anyone actively working on this task?
>
> Thanks
> .
Hi Leon,

I have sent RFCv4  [1] three months ago, and according Andrew' 
suggestion， I'm trying to
continue this work with semantic-patches, and waiting for more comments
for the scheme.
But I'm not familiar with it, and  busy with some other work recently, 
so it got delayed.

Sorry for this. I will speed up it.

[1] https://lore.kernel.org/netdev/YYvKyruLcemj6J+i@lunn.ch/T/

Thanks