netdev - Re: [PATCH net-next v1 1/1] usbnet: add devlink support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YfJ/irQFFh3bv/1U@kroah.com>
Date:   Thu, 27 Jan 2022 12:18:34 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     Oliver Neukum <oneukum@...e.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next v1 1/1] usbnet: add devlink support

On Thu, Jan 27, 2022 at 12:07:42PM +0100, Oleksij Rempel wrote:
> @@ -2137,9 +2183,10 @@ static void usbnet_async_cmd_cb(struct urb *urb)
>  	struct usb_ctrlrequest *req = (struct usb_ctrlrequest *)urb->context;
>  	int status = urb->status;
>  
> -	if (status < 0)
> +	if (status < 0) {
>  		dev_dbg(&urb->dev->dev, "%s failed with %d",
>  			__func__, status);
> +	}
>  
>  	kfree(req);
>  	usb_free_urb(urb);

Also watch out for not-needed changes in your patch submissions.

greg k-h