netdev - Re: [PATCH net-next 01/15] mii: remove mii_lpa_to_linkmode_lpa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220127123630.dcekgawusvmga6ay@skbuf>
Date:   Thu, 27 Jan 2022 14:36:30 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH net-next 01/15] mii: remove
 mii_lpa_to_linkmode_lpa_sgmii()

On Wed, Jan 26, 2022 at 11:10:55AM -0800, Jakub Kicinski wrote:
> The only caller of mii_lpa_to_linkmode_lpa_sgmii()
> disappeared in v5.10.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> --
> CC: Vladimir Oltean <olteanv@...il.com>
> CC: Andrew Lunn <andrew@...n.ch>
> CC: Heiner Kallweit <hkallweit1@...il.com>
> CC: Russell King <linux@...linux.org.uk>
> ---
>  include/linux/mii.h | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/include/linux/mii.h b/include/linux/mii.h
> index 12ea29e04293..b8a1a17a87dd 100644
> --- a/include/linux/mii.h
> +++ b/include/linux/mii.h
> @@ -387,23 +387,6 @@ mii_lpa_mod_linkmode_lpa_sgmii(unsigned long *lp_advertising, u32 lpa)
>  			 speed_duplex == LPA_SGMII_10FULL);
>  }
>  
> -/**
> - * mii_lpa_to_linkmode_adv_sgmii
> - * @advertising: pointer to destination link mode.
> - * @lpa: value of the MII_LPA register
> - *
> - * A small helper function that translates MII_ADVERTISE bits
> - * to linkmode advertisement settings when in SGMII mode.
> - * Clears the old value of advertising.
> - */
> -static inline void mii_lpa_to_linkmode_lpa_sgmii(unsigned long *lp_advertising,
> -						 u32 lpa)
> -{
> -	linkmode_zero(lp_advertising);
> -
> -	mii_lpa_mod_linkmode_lpa_sgmii(lp_advertising, lpa);
> -}
> -

This is also the only caller of mii_lpa_mod_linkmode_lpa_sgmii(), so
that function can be deleted too.

>  /**
>   * mii_adv_mod_linkmode_adv_t
>   * @advertising:pointer to destination link mode.
> -- 
> 2.34.1
>