netdev - Re: [net PATCH 0/9] Fixes for CN10K and CN9xxx platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALHRZuqE3z27wq58a=xdRbjEXLfufN7mkVxANgnSqB0EEFnd3Q@mail.gmail.com>
Date:   Thu, 27 Jan 2022 19:02:30 +0530
From:   sundeep subbaraya <sundeep.lkml@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, hariprasad <hkelam@...vell.com>,
        Geetha sowjanya <gakula@...vell.com>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Subbaraya Sundeep <sbhatta@...vell.com>
Subject: Re: [net PATCH 0/9] Fixes for CN10K and CN9xxx platforms

Hi David and Jakub,

Any comments on this patchset ?

Thanks,
Sundeep

On Fri, Jan 21, 2022 at 12:04 PM Subbaraya Sundeep <sbhatta@...vell.com> wrote:
>
> Hi,
>
> This patchset has consolidated fixes in Octeontx2 driver
> handling CN10K and CN9xxx platforms. When testing the
> new CN10K hardware some issues resurfaced like accessing
> wrong register for CN10K and enabling loopback on not supported
> interfaces. Some fixes are needed for CN9xxx platforms as well.
>
> Below is the description of patches
>
> Patch 1: AF sets RX RSS action for all the VFs when a VF is
> brought up. But when a PF sets RX action for its VF like Drop/Direct
> to a queue in ntuple filter it is not retained because of AF fixup.
> This patch skips modifying VF RX RSS action if PF has already
> set its action.
>
> Patch 2: When configuring backpressure wrong register is being read for
> LBKs hence fixed it.
>
> Patch 3: Some RVU blocks may take longer time to reset but are guaranteed
> to complete the reset. Hence wait till reset is complete.
>
> Patch 4: For enabling LMAC CN10K needs another register compared
> to CN9xxx platforms. Hence changed it.
>
> Patch 5: Adds missing barrier before submitting memory pointer
> to the aura hardware.
>
> Patch 6: Increase polling time while link credit restore and also
> return proper error code when timeout occurs.
>
> Patch 7: Internal loopback not supported on LPCS interfaces like
> SGMII/QSGMII so do not enable it.
>
> Patch 8: When there is a error in message processing, AF sets the error
> response and replies back to requestor. PF forwards a invalid message to
> VF back if AF reply has error in it. This way VF lacks the actual error set
> by AF for its message. This is changed such that PF simply forwards the
> actual reply and let VF handle the error.
>
> Patch 9: ntuple filter with "flow-type ether proto 0x8842 vlan 0x92e"
> was not working since ethertype 0x8842 is NGIO protocol. Hardware
> parser explicitly parses such NGIO packets and sets the packet as
> NGIO and do not set it as tagged packet. Fix this by changing parser
> such that it sets the packet as both NGIO and tagged by using
> separate layer types.
>
> Thanks,
> Sundeep
>
> Geetha sowjanya (5):
>   octeontx2-af: Retry until RVU block reset complete
>   octeontx2-af: cn10k: Use appropriate register for LMAC enable
>   octeontx2-pf: cn10k: Ensure valid pointers are freed to aura
>   octeontx2-af: Increase link credit restore polling timeout
>   octeontx2-af: cn10k: Do not enable RPM loopback for LPC interfaces
>
> Kiran Kumar K (1):
>   octeontx2-af: Add KPU changes to parse NGIO as separate layer
>
> Subbaraya Sundeep (2):
>   octeontx2-af: Do not fixup all VF action entries
>   octeontx2-pf: Forward error codes to VF
>
> Sunil Goutham (1):
>   octeontx2-af: Fix LBK backpressure id count
>
>  drivers/net/ethernet/marvell/octeontx2/af/cgx.c    |  2 +
>  .../ethernet/marvell/octeontx2/af/lmac_common.h    |  3 +
>  drivers/net/ethernet/marvell/octeontx2/af/mbox.h   |  1 +
>  .../ethernet/marvell/octeontx2/af/npc_profile.h    | 70 +++++++++++-----------
>  drivers/net/ethernet/marvell/octeontx2/af/rpm.c    | 66 +++++++++++++++-----
>  drivers/net/ethernet/marvell/octeontx2/af/rpm.h    |  4 ++
>  drivers/net/ethernet/marvell/octeontx2/af/rvu.c    |  7 ++-
>  drivers/net/ethernet/marvell/octeontx2/af/rvu.h    |  1 +
>  .../net/ethernet/marvell/octeontx2/af/rvu_cgx.c    | 14 ++++-
>  .../ethernet/marvell/octeontx2/af/rvu_debugfs.c    |  2 +
>  .../net/ethernet/marvell/octeontx2/af/rvu_nix.c    | 20 +++----
>  .../net/ethernet/marvell/octeontx2/af/rvu_npc.c    | 22 ++++++-
>  .../net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 20 ++++---
>  .../ethernet/marvell/octeontx2/nic/otx2_common.h   |  1 +
>  .../net/ethernet/marvell/octeontx2/nic/otx2_pf.c   |  7 ++-
>  15 files changed, 164 insertions(+), 76 deletions(-)
>
> --
> 2.7.4
>