netdev - Re: [PATCH net] net:amd-xgbe: ensure to reset the tx_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d5d2ab29-60c7-6092-18a6-ce953c4362c2@amd.com>
Date:   Thu, 27 Jan 2022 08:46:24 -0600
From:   Tom Lendacky <thomas.lendacky@....com>
To:     Raju Rangoju <Raju.Rangoju@....com>, davem@...emloft.net,
        kuba@...nel.org
Cc:     netdev@...r.kernel.org, Shyam-sundar.S-k@....com,
        Sudheesh.Mavila@....com
Subject: Re: [PATCH net] net:amd-xgbe: ensure to reset the tx_timer_active
 flag

On 1/27/22 00:02, Raju Rangoju wrote:
> Ensure to reset the tx_timer_active flag in xgbe_stop(),
> otherwise a port restart may result in tx timeout due to
> uncleared flag.
> 
> Fixes: c635eaacbf77 ("amd-xgbe: Remove Tx coalescing")
> Co-developed-by: Sudheesh Mavila <sudheesh.mavila@....com>
> Signed-off-by: Sudheesh Mavila <sudheesh.mavila@....com>
> Signed-off-by: Raju Rangoju <Raju.Rangoju@....com>

Acked-by: Tom Lendacky <thomas.lendacky@....com>

> ---
>   drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> index 492ac383f16d..4949ba69c097 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> @@ -721,7 +721,9 @@ static void xgbe_stop_timers(struct xgbe_prv_data *pdata)
>   		if (!channel->tx_ring)
>   			break;
>   
> +		/* Deactivate the Tx timer */
>   		del_timer_sync(&channel->tx_timer);
> +		channel->tx_timer_active = 0;
>   	}
>   }
>