netdev - Re: [Cake] [PATCH net] sch_cake: diffserv8 CS1 should be bulk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Jan 2022 17:00:54 +0100
From:   Sebastian Moeller <moeller0@....de>
To:     Matt Johnston <matt@...econstruct.com.au>
Cc:     Toke Høiland-Jørgensen <toke@...hat.com>,
        Kevin Darbyshire-Bryant <ldir@...byshire-bryant.me.uk>,
        cake@...ts.bufferbloat.net, Jakub Kicinski <kuba@...nel.org>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [Cake] [PATCH net] sch_cake: diffserv8 CS1 should be bulk

Hi Matt,


> On Jan 27, 2022, at 04:14, Matt Johnston <matt@...econstruct.com.au> wrote:
> 
> On Tue, 2022-01-25 at 12:54 +0100, Sebastian Moeller wrote:
>> 
>> LE(1) is tin 0 the lowest
>> CS1(8) is 1 slightly above LE
>> CS0/BE(0) is 2
>> AF1x (10, 12, 14) are all in tin 1 as is CS1
> ...
>> Just as documented in the code:
>> 
>> *		Bog Standard             (CS0 etc.)
>> *		High Throughput          (AF1x, TOS2)
>> *		Background Traffic       (CS1, LE)
> 
> The documentation doesn't match the code though.

	Since I did not see your original mail, only Toke's response, which documentation is wrong here?


> Almost, but it's off by one.

	I fully believe you, but could you spell it out by showing the line of code and the line of documentation that are off?


> I can submit a patch instead to change the docs, though it's not clear the
> divergence between code and docs was intended in the first place.
> 
> (diffserv8 also needs a description in the cake manpage, I'll send a patch
> for that once the order is clarified)


Regards
	Sebastian
> 
> Cheers,
> Matt
>