netdev - Re: [PATCH bpf-next] bpf: remove unused static inlines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220127082517.1b1bd7e9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 27 Jan 2022 08:25:17 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     John Fastabend <john.fastabend@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Network Development <netdev@...r.kernel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        KP Singh <kpsingh@...nel.org>,
        Jakub Sitnicki <jakub@...udflare.com>,
        Lorenz Bauer <lmb@...udflare.com>,
        Björn Töpel <bjorn@...nel.org>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next] bpf: remove unused static inlines

On Wed, 26 Jan 2022 21:22:03 -0800 Alexei Starovoitov wrote:
> On Wed, Jan 26, 2022 at 9:15 PM John Fastabend <john.fastabend@...il.com> wrote:
> >
> > Jakub Kicinski wrote:  
> > > Remove two dead stubs, sk_msg_clear_meta() was never
> > > used, use of xskq_cons_is_full() got replaced by
> > > xsk_tx_writeable() in v5.10.
> > >
> > > Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> > > ---  
> >
> > Acked-by: John Fastabend <john.fastabend@...il.com>  
> 
> Applied.
> How did you find them?

regex and some bash:

for f in $(sed -n '/static inline [^(]*$/N;s@...tic inline.*[^_a-z0-9A-Z]\([_a-z0-9A-Z]*\)([a-z_].*@\1@p' $(find include/ -type f) ); do cnt=$(git grep $f | wc -l); [ $cnt -le 1 ] && echo $f >> single; done

takes too long to run to put it in a CI directly, unfortunately, 
more intelligence would be needed. Luckily there isn't that many
instances throughout netdev and bpf so perhaps not even worth 
the hassle.