netdev - Re: [PATCH 1/6] net: page_pool: Add alloc stats and fast path stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220127083214.39b80c20@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 27 Jan 2022 08:32:14 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Joe Damato <jdamato@...tly.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        ilias.apalodimas@...aro.org, hawk@...nel.org
Subject: Re: [PATCH 1/6] net: page_pool: Add alloc stats and fast path stat

On Wed, 26 Jan 2022 14:48:15 -0800 Joe Damato wrote:
> Add a stats structure with a an internal alloc structure for holding
> allocation path related stats.
> 
> The alloc structure contains the stat 'fast'. This stat tracks fast
> path allocations.
> 
> A static inline accessor function is exposed for accessing this stat.

> +/**
> + * stats for tracking page_pool events.
> + *
> + * accessor functions for these stats provided below.
> + *
> + * Note that it is the responsibility of the API consumer to ensure that
> + * the page_pool has not been destroyed while accessing stats fields.
> + */
> +struct page_pool_stats {
> +	struct {
> +		u64 fast; /* fast path allocations */
> +	} alloc;
> +};

scripts/kernel-doc says:

include/net/page_pool.h:75: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
 * stats for tracking page_pool events.