netdev - Re: [wpan-next 4/4] net: ieee802154: Add a kernel doc header to the ieee802154

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Jan 2022 17:51:51 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Stefan Schmidt <stefan@...enfreihafen.org>
Cc:     Alexander Aring <alex.aring@...il.com>, linux-wpan@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-wireless@...r.kernel.org,
        David Girault <david.girault@...vo.com>,
        Romuald Despres <romuald.despres@...vo.com>,
        Frederic Blain <frederic.blain@...vo.com>,
        Nicolas Schodet <nico@...fr.eu.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [wpan-next 4/4] net: ieee802154: Add a kernel doc header to the
 ieee802154_addr structure

Hi Stefan,

stefan@...enfreihafen.org wrote on Thu, 27 Jan 2022 17:05:42 +0100:

> Hello.
> 
> On 20.01.22 01:43, Miquel Raynal wrote:
> > From: David Girault <david.girault@...vo.com>
> > 
> > While not being absolutely needed, it at least explain the mode vs. enum
> > fields.
> > 
> > Signed-off-by: David Girault <david.girault@...vo.com>
> > [miquel.raynal@...tlin.com: Isolate this change from a bigger commit and
> >                              reword the comment]
> > Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
> > ---
> >   include/net/cfg802154.h | 10 ++++++++++
> >   1 file changed, 10 insertions(+)
> > 
> > diff --git a/include/net/cfg802154.h b/include/net/cfg802154.h
> > index 4193c242d96e..0b8b1812cea1 100644
> > --- a/include/net/cfg802154.h
> > +++ b/include/net/cfg802154.h
> > @@ -29,6 +29,16 @@ struct ieee802154_llsec_key_id;
> >   struct ieee802154_llsec_key;
> >   #endif /* CONFIG_IEEE802154_NL802154_EXPERIMENTAL */  
> >   > +/**  
> > + * struct ieee802154_addr - IEEE802.15.4 device address
> > + * @mode: Address mode from frame header. Can be one of:
> > + *        - @IEEE802154_ADDR_NONE
> > + *        - @IEEE802154_ADDR_SHORT
> > + *        - @IEEE802154_ADDR_LONG
> > + * @pan_id: The PAN ID this address belongs to
> > + * @short_addr: address if @mode is @IEEE802154_ADDR_SHORT
> > + * @extended_addr: address if @mode is @IEEE802154_ADDR_LONG
> > + */
> >   struct ieee802154_addr {
> >   	u8 mode;
> >   	__le16 pan_id;
> >   
> 
> Same here, please fold into the addr moving patch. I see no reason why splitting these would make it easier or do I miss something?

I really split every change that I could as a habit, but there is no
problem with squashing them both.

Thanks,
Miquèl