netdev - Re: [PATCH v4 net-next] net-core: add InMacErrors counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220126185552.57d5b99e@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Wed, 26 Jan 2022 18:55:52 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jeffrey Ji <jeffreyjilinux@...il.com>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Brian Vazquez <brianvv@...gle.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        jeffreyji <jeffreyji@...gle.com>
Subject: Re: [PATCH v4 net-next] net-core: add InMacErrors counter

On Tue, 25 Jan 2022 23:24:24 +0000 Jeffrey Ji wrote:
> v3-4:
> Remove Change-Id
> 
> v2:
> Use skb_free_reason() for tracing
> Add real-life example in patch msg
> 
> Signed-off-by: jeffreyji <jeffreyji@...gle.com>
> ---
>  include/linux/skbuff.h    |  1 +
>  include/uapi/linux/snmp.h |  1 +
>  net/ipv4/ip_input.c       |  7 +++++--
>  net/ipv4/proc.c           |  1 +
>  net/ipv6/ip6_input.c      | 12 +++++++-----
>  net/ipv6/proc.c           |  1 +
>  6 files changed, 16 insertions(+), 7 deletions(-)
> 
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index bf11e1fbd69b..04a36352f677 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -320,6 +320,7 @@ enum skb_drop_reason {
>  	SKB_DROP_REASON_TCP_CSUM,
>  	SKB_DROP_REASON_TCP_FILTER,
>  	SKB_DROP_REASON_UDP_CSUM,
> +	SKB_DROP_REASON_BAD_DEST_MAC,

Ah, sorry I missed that you pulled in the reason in v3, I thought you'd
leave it to Menglong. Either way is fine, but "BAD_DEST_MAC" is
probably not the most fortunate name for this reason code.
Menglong had OTHERHOST - that seems more intuitive to me, the MAC
address is not bad, it's just not the address of the local host.