netdev - Re: [PATCH v2 net-next] net: drop_monitor: support drop reason

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADxym3YmFhg4eKmQBYQhu+WQTT3KgJmpq_9u0-odKwKpv3DTGw@mail.gmail.com>
Date:   Thu, 27 Jan 2022 11:16:32 +0800
From:   Menglong Dong <menglong8.dong@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Neil Horman <nhorman@...driver.com>,
        David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        David Ahern <dsahern@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Menglong Dong <imagedong@...cent.com>
Subject: Re: [PATCH v2 net-next] net: drop_monitor: support drop reason

On Thu, Jan 27, 2022 at 10:48 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 26 Jan 2022 15:23:06 +0800 menglong8.dong@...il.com wrote:
> > @@ -606,12 +610,17 @@ static int net_dm_packet_report_in_port_put(struct sk_buff *msg, int ifindex,
> >  static int net_dm_packet_report_fill(struct sk_buff *msg, struct sk_buff *skb,
> >                                    size_t payload_len)
> >  {
> > -     u64 pc = (u64)(uintptr_t) NET_DM_SKB_CB(skb)->pc;
> > +     struct net_dm_skb_cb *cb = NET_DM_SKB_CB(skb);
> >       char buf[NET_DM_MAX_SYMBOL_LEN];
> > +     enum skb_drop_reason reason;
> >       struct nlattr *attr;
> >       void *hdr;
> > +     u64 pc;
> >       int rc;
> >
> > +     pc = (u64)(uintptr_t)cb->pc;
> > +     reason = cb->reason;
> > +
> >       hdr = genlmsg_put(msg, 0, 0, &net_drop_monitor_family, 0,
> >                         NET_DM_CMD_PACKET_ALERT);
> >       if (!hdr)
> > @@ -623,6 +632,9 @@ static int net_dm_packet_report_fill(struct sk_buff *msg, struct sk_buff *skb,
> >       if (nla_put_u64_64bit(msg, NET_DM_ATTR_PC, pc, NET_DM_ATTR_PAD))
> >               goto nla_put_failure;
> >
> > +     if (nla_put_u32(msg, NET_DM_ATTR_REASON, reason))
>
> Why the temporary variable instead of referring to cb->reason directly?

Good question......v3 is coming

>
> > +             goto nla_put_failure;