netdev - Re: [PATCH RFC net-next 0/5] bonding: add IPv6 NS/NA monitor support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YfJGFHiiSBJdbxL3@Laptop-X1>
Date:   Thu, 27 Jan 2022 15:13:24 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Nikolay Aleksandrov <nikolay@...dia.com>
Cc:     netdev@...r.kernel.org, Jay Vosburgh <j.vosburgh@...il.com>,
        Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH RFC net-next 0/5] bonding: add IPv6 NS/NA monitor support

On Wed, Jan 26, 2022 at 01:47:45PM +0200, Nikolay Aleksandrov wrote:
> Hi,
> I'd imagine such option to work alongside ARP, i.e. to be able to have both
> ARP and ND targets at the same time. On Rx you can choose which one to check
> based on the protocol, at Tx the same. Then you can reuse and extend most of the
> current arp procedures to handle IPv6 as well. And most of all remove these ifs
> all around the code:
> +		if (bond_slave_is_up(slave)) {
> +			if (bond_do_ns_validate(bond))
> +				bond_ns_send_all(bond, slave);
> +			else
> +				bond_arp_send_all(bond, slave);
> +		}
> 
> and just have one procedure that handles both if there are any targets for that protocol.
> That will completely remove the need for bond_do_ns_validate() helper.

Thanks, I will have a try.
> 
> Also define BOND_MAX_ND_TARGETS as BOND_MAX_ARP_TARGETS just for the namesake.

Ah, yes.
> 
> Another cosmetic nit: adjust for reverse xmas tree ordering of local variables all over.

OK, I will.

Thanks
Hangbin