netdev - Re: [PATCH net-next v6 11/13] net: dsa: realtek: rtl8365mb: add RTL8367RB-VB support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Jan 2022 12:44:55 +0300
From:   Arınç ÜNAL <arinc.unal@...nc9.com>
To:     Luiz Angelo Daros de Luca <luizluca@...il.com>,
        netdev@...r.kernel.org
Cc:     linus.walleij@...aro.org, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, olteanv@...il.com, alsi@...g-olufsen.dk,
        frank-w@...lic-files.de, davem@...emloft.net, kuba@...nel.org
Subject: Re: [PATCH net-next v6 11/13] net: dsa: realtek: rtl8365mb: add
 RTL8367RB-VB support

On 28/01/2022 09:05, Luiz Angelo Daros de Luca wrote:
> RTL8367RB-VB is a 5+2 port 10/100/1000M Ethernet switch.
> It is similar to RTL8367S but in this version, both
> external interfaces are RGMII.
> 
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@...il.com>
> ---
>   drivers/net/dsa/realtek/rtl8365mb.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c
> index 6974decf5ebe..174496e4d736 100644
> --- a/drivers/net/dsa/realtek/rtl8365mb.c
> +++ b/drivers/net/dsa/realtek/rtl8365mb.c
> @@ -108,6 +108,9 @@
>   #define RTL8365MB_CHIP_ID_8367S		0x6367
>   #define RTL8365MB_CHIP_VER_8367S	0x00A0
>   
> +#define RTL8365MB_CHIP_ID_8367RB	0x6367
> +#define RTL8365MB_CHIP_VER_8367RB	0x0020
> +
>   /* Family-specific data and limits */
>   #define RTL8365MB_PHYADDRMAX		7
>   #define RTL8365MB_NUM_PHYREGS		32
> @@ -1979,6 +1982,11 @@ static int rtl8365mb_detect(struct realtek_priv *priv)
>   				 "found an RTL8365MB-VC switch (ver=0x%04x)\n",
>   				 chip_ver);
>   			break;
> +		case RTL8365MB_CHIP_VER_8367RB:
> +			dev_info(priv->dev,
> +				 "found an RTL8367RB-VB switch (ver=0x%04x)\n",
> +				 chip_ver);
> +			break;
>   		case RTL8365MB_CHIP_VER_8367S:
>   			dev_info(priv->dev,
>   				 "found an RTL8367S switch (ver=0x%04x)\n",

You should mention the support for this chip model on kconfig like on 
"net: dsa: realtek: rtl8365mb: add RTL8367S support".

Don't you also need to match the "realtek,rtl8367rb" compatible string 
to rtl8365mb_variant on SMI and MDIO drivers?

Arınç