lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 28 Jan 2022 15:20:10 +0000 From: patchwork-bot+netdevbpf@...nel.org To: Jisheng Zhang <jszhang@...nel.org> Cc: peppe.cavallaro@...com, alexandre.torgue@...s.st.com, joabreu@...opsys.com, davem@...emloft.net, kuba@...nel.org, mcoquelin.stm32@...il.com, qiangqing.zhang@....com, netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: stmmac: properly handle with runtime pm in stmmac_dvr_remove() Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@...emloft.net>: On Fri, 28 Jan 2022 22:15:50 +0800 you wrote: > There are two issues with runtime pm handling in stmmac_dvr_remove(): > > 1. the mac is runtime suspended before stopping dma and rx/tx. We > need to ensure the device is properly resumed back. > > 2. the stmmaceth clk enable/disable isn't balanced in both exit and > error handling code path. Take the exit code path for example, when we > unbind the driver or rmmod the driver module, the mac is runtime > suspended as said above, so the stmmaceth clk is disabled, but > stmmac_dvr_remove() > stmmac_remove_config_dt() > clk_disable_unprepare() > CCF will complain this time. The error handling code path suffers > from the similar situtaion. > > [...] Here is the summary with links: - net: stmmac: properly handle with runtime pm in stmmac_dvr_remove() https://git.kernel.org/netdev/net/c/6449520391df You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Powered by blists - more mailing lists