netdev - Re: [PATCH 1/2] net: stmmac: added Baikal-T1/M SoCs glue layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YfQhCMrySoza9Ykt@asheplyakov-rocket>
Date:   Fri, 28 Jan 2022 21:00:19 +0400
From:   Alexey Sheplyakov <asheplyakov@...ealt.ru>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        Dmitry Dunaev <dmitry.dunaev@...kalelectronics.ru>
Subject: Re: [PATCH 1/2] net: stmmac: added Baikal-T1/M SoCs glue layer

Hi, Jakub,

On Wed, Jan 26, 2022 at 05:00:42PM -0800, Jakub Kicinski wrote:
> On Wed, 26 Jan 2022 12:44:55 +0400 Alexey Sheplyakov wrote:
> > The gigabit Ethernet controller available in Baikal-T1 and Baikal-M
> > SoCs is a Synopsys DesignWare MAC IP core, already supported by
> > the stmmac driver.
> > 
> > This patch implements some SoC specific operations (DMA reset and
> > speed fixup) necessary for Baikal-T1/M variants.
> 
> drivers/net/ethernet/stmicro/stmmac/dwmac-baikal.c:33:13: warning: unused variable ‘err’ [-Wunused-variable]
>    33 |         int err;
>       |             ^~~

thanks for spotting this. I've sent v2 patchset which appears to compile
with -Werror.

Best regards,
	Alexey