netdev - Re: [PATCH net-next v4 2/5] txhash: Add socket option to control TX hash rethink behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202201290514.oladOq5e-lkp@intel.com>
Date:   Sat, 29 Jan 2022 06:05:19 +0800
From:   kernel test robot <lkp@...el.com>
To:     Akhmat Karakotov <hmukos@...dex-team.ru>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, davem@...emloft.net, kuba@...nel.org,
        edumazet@...gle.com, eric.dumazet@...il.com, bpf@...r.kernel.org,
        ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
        tom@...bertland.com
Subject: Re: [PATCH net-next v4 2/5] txhash: Add socket option to control TX
 hash rethink behavior

Hi Akhmat,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Akhmat-Karakotov/Make-hash-rethink-configurable/20220129-034621
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git b76bbb34dc80258f5079b4067f0dae07b394b8fe
config: nds32-allnoconfig (https://download.01.org/0day-ci/archive/20220129/202201290514.oladOq5e-lkp@intel.com/config)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/92d1267cbe457eff1ea65aa32f38356861bfa5f5
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Akhmat-Karakotov/Make-hash-rethink-configurable/20220129-034621
        git checkout 92d1267cbe457eff1ea65aa32f38356861bfa5f5
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nds32 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/tcp.h:19,
                    from include/linux/ipv6.h:92,
                    from include/net/ipv6.h:12,
                    from include/linux/sunrpc/clnt.h:29,
                    from include/linux/nfs_fs.h:32,
                    from init/do_mounts.c:23:
   include/net/sock.h: In function 'sk_rethink_txhash':
>> include/net/sock.h:2071:34: error: 'struct sock' has no member named 'sk_txrehash'; did you mean 'sk_txhash'?
    2071 |         if (sk->sk_txhash && sk->sk_txrehash == SOCK_TXREHASH_ENABLED) {
         |                                  ^~~~~~~~~~~
         |                                  sk_txhash
--
   In file included from fs/io_uring.c:63:
   include/net/sock.h: In function 'sk_rethink_txhash':
>> include/net/sock.h:2071:34: error: 'struct sock' has no member named 'sk_txrehash'; did you mean 'sk_txhash'?
    2071 |         if (sk->sk_txhash && sk->sk_txrehash == SOCK_TXREHASH_ENABLED) {
         |                                  ^~~~~~~~~~~
         |                                  sk_txhash
   fs/io_uring.c: In function '__io_submit_flush_completions':
   fs/io_uring.c:2523:40: warning: variable 'prev' set but not used [-Wunused-but-set-variable]
    2523 |         struct io_wq_work_node *node, *prev;
         |                                        ^~~~
--
   In file included from include/linux/tcp.h:19,
                    from include/linux/ipv6.h:92,
                    from include/net/addrconf.h:52,
                    from lib/vsprintf.c:40:
   include/net/sock.h: In function 'sk_rethink_txhash':
>> include/net/sock.h:2071:34: error: 'struct sock' has no member named 'sk_txrehash'; did you mean 'sk_txhash'?
    2071 |         if (sk->sk_txhash && sk->sk_txrehash == SOCK_TXREHASH_ENABLED) {
         |                                  ^~~~~~~~~~~
         |                                  sk_txhash
   lib/vsprintf.c: In function 'va_format':
   lib/vsprintf.c:1684:9: warning: function 'va_format' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
    1684 |         buf += vsnprintf(buf, end > buf ? end - buf : 0, va_fmt->fmt, va);
         |         ^~~


vim +2071 include/net/sock.h

  2068	
  2069	static inline bool sk_rethink_txhash(struct sock *sk)
  2070	{
> 2071		if (sk->sk_txhash && sk->sk_txrehash == SOCK_TXREHASH_ENABLED) {
  2072			sk_set_txhash(sk);
  2073			return true;
  2074		}
  2075		return false;
  2076	}
  2077	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org