netdev - Re: [RESEND PATCH net-next 2/2] net: hns3: add ethtool priv-flag for TX push

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2b7029d4-c1a7-93af-1846-7b91703f9edf@huawei.com>
Date:   Sat, 29 Jan 2022 09:14:15 +0800
From:   "huangguangbin (A)" <huangguangbin2@...wei.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <davem@...emloft.net>, <wangjie125@...wei.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <lipeng321@...wei.com>, <chenhao288@...ilicon.com>
Subject: Re: [RESEND PATCH net-next 2/2] net: hns3: add ethtool priv-flag for
 TX push



On 2022/1/26 11:55, Jakub Kicinski wrote:
> On Tue, 25 Jan 2022 15:21:49 +0800 Guangbin Huang wrote:
>> From: Yufeng Mo <moyufeng@...wei.com>
>>
>> Add a control private flag in ethtool for enable/disable
>> TX push feature.
> 
> I think it's a pretty standard feature for NICs which also support RDMA.
> Mellanox/nVidia has it (or at least it the previous gen HW did),
> Broadcom's bnxt driver does it as well.
> 
> Can we make this a standard knob via ethtool? Not entirely sure under
> which switch, maybe it's okay to add it under -g? Perhaps we need a new
> command similar to -k but for features contained entirely to the driver?
> .
> 
Hi Jakub,
We consider adding a new command for this feature. We will send RFC after we finish it.