netdev - Re: [PATCH 1/2] ravb: ravb_close() always returns 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50b5fab3-6e06-165d-43eb-dc17c7b3ff99@omp.ru>
Date:   Sat, 29 Jan 2022 13:38:01 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH 1/2] ravb: ravb_close() always returns 0

Hello!

On 1/29/22 12:51 AM, Jakub Kicinski wrote:

>> ravb_close() always returns 0, hence the check in ravb_wol_restore() is
>> pointless (however, we cannot change the prototype of ravb_close() as it
>> implements the driver's ndo_stop() method).
>>
>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>> analysis tool.
>>
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@....ru>
>> ---
>>  drivers/net/ethernet/renesas/ravb_main.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
>> index b215cde68e10..02fa8cfc2b7b 100644
>> --- a/drivers/net/ethernet/renesas/ravb_main.c
>> +++ b/drivers/net/ethernet/renesas/ravb_main.c
>> @@ -2863,9 +2863,7 @@ static int ravb_wol_restore(struct net_device *ndev)
>>  	/* Disable MagicPacket */
>>  	ravb_modify(ndev, ECMR, ECMR_MPDE, 0);
>>  
>> -	ret = ravb_close(ndev);
>> -	if (ret < 0)
>> -		return ret;
>> +	ravb_close(ndev);
>>  
>>  	return disable_irq_wake(priv->emac_irq);
>>  }
> 
> drivers/net/ethernet/renesas/ravb_main.c:2857:13: warning: unused variable ‘ret’ [-Wunused-variable]
>  2857 |         int ret;
>       |             ^~~

   Oops, sorry about that!
   This patch was created during the merge window and when it finally closed, I rushed
to send this series before the end of week, and forgot to sanity check it (thinking it
has been checked already)... :-/
   I'll fix and resend...

MBR, Sergey