lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 29 Jan 2022 15:38:57 -0800 From: Joe Damato <jdamato@...tly.com> To: netdev@...r.kernel.org, kuba@...nel.org, ilias.apalodimas@...aro.org, davem@...emloft.net, hawk@...nel.org Cc: Joe Damato <jdamato@...tly.com> Subject: [net-next v2 07/10] page_pool: Add stat tracking empty ring Add a stat tracking when the ptr ring is empty. When this occurs, the cache could not be refilled and a slow path allocation was forced. Signed-off-by: Joe Damato <jdamato@...tly.com> --- include/net/page_pool.h | 3 +++ net/core/page_pool.c | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/include/net/page_pool.h b/include/net/page_pool.h index f59b8a9..ed2bc73 100644 --- a/include/net/page_pool.h +++ b/include/net/page_pool.h @@ -146,6 +146,9 @@ struct page_pool_stats { u64 fast; /* fast path allocations */ u64 slow; /* slow-path order-0 allocations */ u64 slow_high_order; /* slow-path high order allocations */ + u64 empty; /* failed refills due to empty ptr ring, forcing + * slow path allocation + */ } alloc; }; diff --git a/net/core/page_pool.c b/net/core/page_pool.c index 24306d6..9d20b12 100644 --- a/net/core/page_pool.c +++ b/net/core/page_pool.c @@ -131,8 +131,10 @@ static struct page *page_pool_refill_alloc_cache(struct page_pool *pool) int pref_nid; /* preferred NUMA node */ /* Quicker fallback, avoid locks when ring is empty */ - if (__ptr_ring_empty(r)) + if (__ptr_ring_empty(r)) { + page_pool_stat_alloc_inc(empty); return NULL; + } /* Softirq guarantee CPU and thus NUMA node is stable. This, * assumes CPU refilling driver RX-ring will also run RX-NAPI. -- 2.7.4
Powered by blists - more mailing lists