netdev - Re: [PATCH net-next 1/1] net/sched: Enable tc skb ext allocation on chain miss only when needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 31 Jan 2022 00:52:33 +0800
From:   kernel test robot <lkp@...el.com>
To:     Paul Blakey <paulb@...dia.com>, dev@...nvswitch.org,
        netdev@...r.kernel.org, Cong Wang <xiyou.wangcong@...il.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Pravin B Shelar <pshelar@....org>, davem@...emloft.net,
        Jiri Pirko <jiri@...dia.com>, Jakub Kicinski <kuba@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org
Subject: Re: [PATCH net-next 1/1] net/sched: Enable tc skb ext allocation on
 chain miss only when needed

Hi Paul,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Paul-Blakey/net-sched-Enable-tc-skb-ext-allocation-on-chain-miss-only-when-needed/20220130-203224
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git ff58831fa02deb42fd731f830d8d9ec545573c7c
config: x86_64-randconfig-a016 (https://download.01.org/0day-ci/archive/20220131/202201310016.Z4iqHnpx-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project f1c18acb07aa40f42b87b70462a6d1ab77a4825c)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/0bc6313c4ce18444ed88c99b19d0cb1682772988
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Paul-Blakey/net-sched-Enable-tc-skb-ext-allocation-on-chain-miss-only-when-needed/20220130-203224
        git checkout 0bc6313c4ce18444ed88c99b19d0cb1682772988
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> net/sched/cls_api.c:55:6: error: redefinition of 'tc_skb_ext_tc_ovs_enable'
   void tc_skb_ext_tc_ovs_enable(void)
        ^
   include/net/pkt_cls.h:1037:20: note: previous definition is here
   static inline void tc_skb_ext_tc_ovs_enable(void) { }
                      ^
>> net/sched/cls_api.c:61:6: error: redefinition of 'tc_skb_ext_tc_ovs_disable'
   void tc_skb_ext_tc_ovs_disable(void)
        ^
   include/net/pkt_cls.h:1038:20: note: previous definition is here
   static inline void tc_skb_ext_tc_ovs_disable(void) { }
                      ^
   2 errors generated.


vim +/tc_skb_ext_tc_ovs_enable +55 net/sched/cls_api.c

    54	
  > 55	void tc_skb_ext_tc_ovs_enable(void)
    56	{
    57		static_branch_inc(&tc_skb_ext_tc_ovs);
    58	}
    59	EXPORT_SYMBOL(tc_skb_ext_tc_ovs_enable);
    60	
  > 61	void tc_skb_ext_tc_ovs_disable(void)
    62	{
    63		static_branch_dec(&tc_skb_ext_tc_ovs);
    64	}
    65	EXPORT_SYMBOL(tc_skb_ext_tc_ovs_disable);
    66	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org