netdev - Re: [PATCH wpan-next v2 1/2] net: ieee802154: Move the IEEE 802.15.4 Kconfig main entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB_54W6Lc4P8WXR81311qH2XdDd2tjG1yEXo+UEXFcMX=q_Q5Q@mail.gmail.com>
Date:   Sun, 30 Jan 2022 15:47:05 -0500
From:   Alexander Aring <alex.aring@...il.com>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
Cc:     Stefan Schmidt <stefan@...enfreihafen.org>,
        linux-wpan - ML <linux-wpan@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        David Girault <david.girault@...vo.com>,
        Romuald Despres <romuald.despres@...vo.com>,
        Frederic Blain <frederic.blain@...vo.com>,
        Nicolas Schodet <nico@...fr.eu.org>
Subject: Re: [PATCH wpan-next v2 1/2] net: ieee802154: Move the IEEE 802.15.4
 Kconfig main entries

Hi,

On Fri, Jan 28, 2022 at 6:20 AM Miquel Raynal <miquel.raynal@...tlin.com> wrote:
>
> From: David Girault <david.girault@...vo.com>
>
> It makes certainly more sense to have all the low-range wireless
> protocols such as Bluetooth, IEEE 802.11 (WiFi) and IEEE 802.15.4
> together, so let's move the main IEEE 802.15.4 stack Kconfig entry at a
> better location.
>
> As the softMAC layer has no meaning outside of the IEEE 802.15.4 stack
> and cannot be used without it, also move the mac802154 menu inside
> ieee802154/.
>
> Signed-off-by: David Girault <david.girault@...vo.com>
> [miquel.raynal@...tlin.com: Isolate this change from a bigger commit and
> rewrite the commit message.]
> Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
> ---
>  net/Kconfig            | 3 +--
>  net/ieee802154/Kconfig | 1 +
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/Kconfig b/net/Kconfig
> index 8a1f9d0287de..a5e31078fd14 100644
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -228,8 +228,6 @@ source "net/x25/Kconfig"
>  source "net/lapb/Kconfig"
>  source "net/phonet/Kconfig"
>  source "net/6lowpan/Kconfig"
> -source "net/ieee802154/Kconfig"
> -source "net/mac802154/Kconfig"
>  source "net/sched/Kconfig"
>  source "net/dcb/Kconfig"
>  source "net/dns_resolver/Kconfig"
> @@ -380,6 +378,7 @@ source "net/mac80211/Kconfig"
>
>  endif # WIRELESS
>
> +source "net/ieee802154/Kconfig"

I would argue here that IEEE 802.15.4 is no "network option". However
I was talking once about moving it, but people don't like to move
things there around.
In my opinion there is no formal place to "have all the low-range
wireless such as Bluetooth, IEEE 802.11 (WiFi) and IEEE 802.15.4
together". If you bring all subsystems together and put them into an
own menuentry this would look different.

You forgot to move mac802154 as well here, even though it's changed in
the following patch.

If nobody else complains about moving Kconfig entries here around it
looks okay for me.

- Alex