[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <b1a013a9-0f67-3723-d524-0210ca8cbe9a@linuxfoundation.org>
Date: Mon, 31 Jan 2022 08:40:23 -0700
From: Shuah Khan <skhan@...uxfoundation.org>
To: Jamal Hadi Salim <jhs@...atatu.com>,
Davide Caratti <dcaratti@...hat.com>
Cc: Victor Nogueira <victor@...atatu.com>,
Baowen Zheng <baowen.zheng@...igine.com>,
Simon Horman <simon.horman@...igine.com>,
Linux Kernel Network Developers <netdev@...r.kernel.org>,
Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
Vlad Buslov <vladbu@...dia.com>,
David Ahern <dsahern@...il.com>, shuah@...nel.org,
Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: tdc errors
On 1/31/22 5:46 AM, Jamal Hadi Salim wrote:
> On 2022-01-21 11:27, Shuah Khan wrote:
>> On 1/21/22 7:11 AM, Jamal Hadi Salim wrote:
>>> On 2022-01-21 04:36, Davide Caratti wrote:
>>>> On Thu, Jan 20, 2022 at 8:34 PM Jamal Hadi Salim <jhs@...atatu.com> wrote:
>
> [..]
>
>
>>
>> Several tests check for config support for their dependencies in their
>> test code - I don't see any of those in tc-testing. Individual tests
>> are supposed to check for not just the config dependencies, but also
>> any feature dependency e.g syscall/ioctl.
>>
>> Couple of way to fix this problem for tc-testing - enhance the test to
>> check for dependencies and skip with a clear message on why test is
>> skipped.
>>
>> A second option is enhancing the tools/testing/selftests/kselftest_deps.sh
>> script that checks for build depedencies. This tool can be enhanced easily
>> to check for run-time dependencies and use this in your automation.
>>
>> Usage: ./kselftest_deps.sh -[p] <compiler> [test_name]
>>
>> kselftest_deps.sh [-p] gcc
>> kselftest_deps.sh [-p] gcc vm
>> kselftest_deps.sh [-p] aarch64-linux-gnu-gcc
>> kselftest_deps.sh [-p] aarch64-linux-gnu-gcc vm
>>
>> - Should be run in selftests directory in the kernel repo.
>> - Checks if Kselftests can be built/cross-built on a system.
>> - Parses all test/sub-test Makefile to find library dependencies.
>> - Runs compile test on a trivial C file with LDLIBS specified
>> in the test Makefiles to identify missing library dependencies.
>> - Prints suggested target list for a system filtering out tests
>> failed the build dependency check from the TARGETS in Selftests
>> main Makefile when optional -p is specified.
>> - Prints pass/fail dependency check for each tests/sub-test.
>> - Prints pass/fail targets and libraries.
>> - Default: runs dependency checks on all tests.
>> - Optional test name can be specified to check dependencies for it.
>>
>
> Thanks Shuah. We'll look at this approach.
> Question: How do we get reports when the bot finds a regression?
>
>
You might be able to subscribe to test ring notification or subscribe
to Linux stable mailing list.
thanks,
-- Shuah
Powered by blists - more mailing lists