netdev - Re: [PATCH intel-net] ice: avoid XDP checks in ice_clean_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220131155233.17962-1-alexandr.lobakin@intel.com>
Date:   Mon, 31 Jan 2022 16:52:33 +0100
From:   Alexander Lobakin <alexandr.lobakin@...el.com>
To:     Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc:     Alexander Lobakin <alexandr.lobakin@...el.com>,
        intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        bpf@...r.kernel.org, anthony.l.nguyen@...el.com, kuba@...nel.org,
        davem@...emloft.net, magnus.karlsson@...el.com,
        jesse.brandeburg@...el.com
Subject: Re: [PATCH intel-net] ice: avoid XDP checks in ice_clean_tx_irq()

From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Date: Mon, 31 Jan 2022 14:49:21 +0100

> Commit 9610bd988df9 ("ice: optimize XDP_TX workloads") introduced
> dedicated Tx IRQ cleaning routine dedicated for XDP rings. Currently it

  ^^^^^^^^^                         ^^^^^^^^^

dedicated-dedicated :z

> is impossible to call ice_clean_tx_irq() against XDP ring, so it is safe
> to drop ice_ring_is_xdp() calls in there.
> 
> Fixes: 1c96c16858ba ("ice: update to newer kernel API")
> Fixes: cc14db11c8a4 ("ice: use prefetch methods")
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_txrx.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_txrx.c b/drivers/net/ethernet/intel/ice/ice_txrx.c
> index 7d8824b4c8ff..25a5a3f2d107 100644
> --- a/drivers/net/ethernet/intel/ice/ice_txrx.c
> +++ b/drivers/net/ethernet/intel/ice/ice_txrx.c
> @@ -223,8 +223,7 @@ static bool ice_clean_tx_irq(struct ice_tx_ring *tx_ring, int napi_budget)
>  	struct ice_tx_buf *tx_buf;
>  
>  	/* get the bql data ready */
> -	if (!ice_ring_is_xdp(tx_ring))
> -		netdev_txq_bql_complete_prefetchw(txring_txq(tx_ring));
> +	netdev_txq_bql_complete_prefetchw(txring_txq(tx_ring));
>  
>  	tx_buf = &tx_ring->tx_buf[i];
>  	tx_desc = ICE_TX_DESC(tx_ring, i);
> @@ -313,10 +312,6 @@ static bool ice_clean_tx_irq(struct ice_tx_ring *tx_ring, int napi_budget)
>  	tx_ring->next_to_clean = i;
>  
>  	ice_update_tx_ring_stats(tx_ring, total_pkts, total_bytes);
> -
> -	if (ice_ring_is_xdp(tx_ring))
> -		return !!budget;
> -
>  	netdev_tx_completed_queue(txring_txq(tx_ring), total_pkts, total_bytes);
>  
>  #define TX_WAKE_THRESHOLD ((s16)(DESC_NEEDED * 2))

For the code:

Reviewed-by: Alexander Lobakin <alexandr.lobakin@...el.com>

> -- 
> 2.33.1

Thanks!
Al