netdev - Re: [PATCH v3 net-next 4/7] net: ipv4: use kfree_skb_reason() in ip_rcv_finish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1d3869f-fb8b-4396-a2fb-38d0c6d193de@gmail.com>
Date:   Mon, 31 Jan 2022 10:45:46 -0700
From:   David Ahern <dsahern@...il.com>
To:     menglong8.dong@...il.com, dsahern@...nel.org, kuba@...nel.org
Cc:     rostedt@...dmis.org, mingo@...hat.com, davem@...emloft.net,
        yoshfuji@...ux-ipv6.org, pablo@...filter.org, kadlec@...filter.org,
        fw@...len.de, imagedong@...cent.com, edumazet@...gle.com,
        alobakin@...me, paulb@...dia.com, keescook@...omium.org,
        talalahmad@...gle.com, haokexin@...il.com, memxor@...il.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        cong.wang@...edance.com, mengensun@...cent.com
Subject: Re: [PATCH v3 net-next 4/7] net: ipv4: use kfree_skb_reason() in
 ip_rcv_finish_core()

On 1/28/22 12:33 AM, menglong8.dong@...il.com wrote:
> From: Menglong Dong <imagedong@...cent.com>
> 
> Replace kfree_skb() with kfree_skb_reason() in ip_rcv_finish_core(),
> following drop reasons are introduced:
> 
> SKB_DROP_REASON_IP_RPFILTER
> SKB_DROP_REASON_UNICAST_IN_L2_MULTICAST
> 
> Signed-off-by: Menglong Dong <imagedong@...cent.com>
> ---
> v2:
> - remove SKB_DROP_REASON_EARLY_DEMUX and SKB_DROP_REASON_IP_ROUTE_INPUT
> - add document for SKB_DROP_REASON_UNICAST_IN_L2_MULTICAST and
>   SKB_DROP_REASON_IP_RPFILTER
> ---
>  include/linux/skbuff.h     |  9 +++++++++
>  include/trace/events/skb.h |  3 +++
>  net/ipv4/ip_input.c        | 14 ++++++++++----
>  3 files changed, 22 insertions(+), 4 deletions(-)
> 


Reviewed-by: David Ahern <dsahern@...nel.org>