netdev - Re: [PATCH net-next 1/2] uapi: ioam: Insertion frequency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220131105458.4a7c182f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 31 Jan 2022 10:54:58 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Justin Iurman <justin.iurman@...ege.be>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        yoshfuji@...ux-ipv6.org, dsahern@...nel.org
Subject: Re: [PATCH net-next 1/2] uapi: ioam: Insertion frequency

On Sat, 29 Jan 2022 12:24:47 +0100 (CET) Justin Iurman wrote:
> >> +	IOAM6_IPTUNNEL_FREQ_K,		/* s32 */
> >> +	IOAM6_IPTUNNEL_FREQ_N,		/* s32 */  
> > 
> > You can't insert into the middle of a uAPI enum. Binary compatibility.  
> 
> Is it really the middle? I recall adding the "mode" at the top (still
> below the "_UNSPEC"), which I thought was correct at that time (and had
> no objection).

Maybe because both changes were made in the same kernel release?
Not sure.

> That's why I did the same here. Should I move it to the end, then?

You have to move it. I don't see how this patch as is wouldn't change
the value of IOAM6_IPTUNNEL_MODE.