netdev - Re: [PATCH net-next 1/5] ptp: unregister virtual clocks when unregistering physical clock.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yfe0+N2cMJaWNbo7@localhost>
Date:   Mon, 31 Jan 2022 11:07:52 +0100
From:   Miroslav Lichvar <mlichvar@...hat.com>
To:     Vinicius Costa Gomes <vinicius.gomes@...el.com>
Cc:     netdev@...r.kernel.org, Yangbo Lu <yangbo.lu@....com>,
        Yang Yingliang <yangyingliang@...wei.com>,
        Richard Cochran <richardcochran@...il.com>,
        Vladimir Oltean <olteanv@...il.com>
Subject: Re: [PATCH net-next 1/5] ptp: unregister virtual clocks when
 unregistering physical clock.

On Thu, Jan 27, 2022 at 03:58:02PM -0800, Vinicius Costa Gomes wrote:
> Miroslav Lichvar <mlichvar@...hat.com> writes:
> 
> > When unregistering a physical clock which has some virtual clocks,
> > unregister the virtual clocks with it.

> I am not against this change, but I think this problem was discussed
> before and the suggestions were to fix it differently:
> 
> https://lore.kernel.org/all/20210807144332.szyazdfl42abwzmd@skbuf/

Is a linked device supposed to be unregistered automatically before
the parent? The referenced document mentions only suspending
and resuming, nothing about unregistering.

I tried

	device_link_add(parent, &ptp->dev, DL_FLAG_AUTOREMOVE_CONSUMER);

and also with no flags specified, but it didn't seem to do anything
for the vclock. It was still oopsing.

Any hints?

-- 
Miroslav Lichvar