netdev - Re: [PATCH net-next] net: hsr: use hlist_head instead of list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202201311904.frzcODO4-lkp@intel.com>
Date:   Mon, 31 Jan 2022 19:46:40 +0800
From:   kernel test robot <lkp@...el.com>
To:     Juhee Kang <claudiajkang@...il.com>, davem@...emloft.net,
        kuba@...nel.org, netdev@...r.kernel.org, arvid.brodin@...en.se
Cc:     kbuild-all@...ts.01.org
Subject: Re: [PATCH net-next] net: hsr: use hlist_head instead of list_head
 for mac addresses

Hi Juhee,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Juhee-Kang/net-hsr-use-hlist_head-instead-of-list_head-for-mac-addresses/20220131-170414
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git ff58831fa02deb42fd731f830d8d9ec545573c7c
config: nios2-randconfig-s031-20220131 (https://download.01.org/0day-ci/archive/20220131/202201311904.frzcODO4-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/4610359df4a1f524fe7c2b85702a561ebf53fee8
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Juhee-Kang/net-hsr-use-hlist_head-instead-of-list_head-for-mac-addresses/20220131-170414
        git checkout 4610359df4a1f524fe7c2b85702a561ebf53fee8
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=nios2 SHELL=/bin/bash net/hsr/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
>> net/hsr/hsr_framereg.c:52:17: sparse: sparse: cast removes address space '__rcu' of expression
   net/hsr/hsr_framereg.c:101:33: sparse: sparse: cast removes address space '__rcu' of expression
   net/hsr/hsr_framereg.c:122:25: sparse: sparse: cast removes address space '__rcu' of expression
   net/hsr/hsr_framereg.c:595:25: sparse: sparse: cast removes address space '__rcu' of expression

vim +/__rcu +52 net/hsr/hsr_framereg.c

    46	
    47	bool hsr_addr_is_self(struct hsr_priv *hsr, unsigned char *addr)
    48	{
    49		struct hsr_node *node;
    50	
    51		node = hlist_empty(&hsr->self_node_db) ? NULL :
  > 52			hlist_entry(hlist_first_rcu(&hsr->self_node_db),
    53				    struct hsr_node, mac_list);
    54		if (!node) {
    55			WARN_ONCE(1, "HSR: No self node\n");
    56			return false;
    57		}
    58	
    59		if (ether_addr_equal(addr, node->macaddress_A))
    60			return true;
    61		if (ether_addr_equal(addr, node->macaddress_B))
    62			return true;
    63	
    64		return false;
    65	}
    66	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org