netdev - Re: [PATCH net-next v2 1/1] net/sched: Enable tc skb ext allocation on chain miss only when needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0e202f7c-0558-6050-54c9-e1e28b1bfaa3@mojatatu.com>
Date:   Tue, 1 Feb 2022 18:18:29 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Paul Blakey <paulb@...dia.com>, dev@...nvswitch.org,
        netdev@...r.kernel.org, Cong Wang <xiyou.wangcong@...il.com>,
        Pravin B Shelar <pshelar@....org>, davem@...emloft.net,
        Jiri Pirko <jiri@...dia.com>, Jakub Kicinski <kuba@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>
Cc:     Saeed Mahameed <saeedm@...dia.com>, Oz Shlomo <ozsh@...dia.com>,
        Vlad Buslov <vladbu@...dia.com>, Roi Dayan <roid@...dia.com>
Subject: Re: [PATCH net-next v2 1/1] net/sched: Enable tc skb ext allocation
 on chain miss only when needed

On 2022-02-01 12:52, Paul Blakey wrote:
> Tc skb extension is used to send miss info from tc to ovs datapath
> module, and is currently always allocated even if it will not
> be used by ovs datapath (as it depends on a requested feature).
> 
> Export the static key which is used by openvswitch module to
> guard this code path as well, so it will be skipped if ovs
> datapath doesn't need it. Enable this code path once
> ovs datapath needs it.

Why the name tc_skb_ext_tc_ovs_XXX? This is a generic feature
which could be used for other purposes within tc and outside
of ovs. Suggestion to rename to tc_skb_ext_tc_XXX

cheers,
jamal