netdev - Re: [PATCH ipsec-next] xfrm: delete not-used XFRM_OFFLOAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220201065836.GT1223722@gauss3.secunet.de>
Date:   Tue, 1 Feb 2022 07:58:36 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     "David S . Miller" <davem@...emloft.net>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Leon Romanovsky <leonro@...dia.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH ipsec-next] xfrm: delete not-used XFRM_OFFLOAD_IPV6 define

On Thu, Jan 27, 2022 at 08:24:58PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@...dia.com>
> 
> XFRM_OFFLOAD_IPV6 define was exposed in the commit mentioned in the
> fixes line, but it is never been used both in the kernel and in the
> user space. So delete it.

How can you be sure that is is not used in userspace? At least some
versions of strongswan set that flag. So even if it is meaningless
in the kernel, we can't remove it.

> 
> Fixes: d77e38e612a0 ("xfrm: Add an IPsec hardware offloading API")
> Signed-off-by: Leon Romanovsky <leonro@...dia.com>
> ---
>  include/uapi/linux/xfrm.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/uapi/linux/xfrm.h b/include/uapi/linux/xfrm.h
> index 4e29d7851890..2c822671cc32 100644
> --- a/include/uapi/linux/xfrm.h
> +++ b/include/uapi/linux/xfrm.h
> @@ -511,7 +511,6 @@ struct xfrm_user_offload {
>  	int				ifindex;
>  	__u8				flags;
>  };
> -#define XFRM_OFFLOAD_IPV6	1
>  #define XFRM_OFFLOAD_INBOUND	2
>  
>  struct xfrm_userpolicy_default {
> -- 
> 2.34.1