[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 02 Feb 2022 15:29:10 +0100
From: Antoine Tenart <atenart@...nel.org>
To: Paolo Abeni <pabeni@...hat.com>, davem@...emloft.net,
kuba@...nel.org
Cc: netdev@...r.kernel.org, vladbu@...dia.com, pshelar@....org
Subject: Re: [PATCH net 1/2] net: do not keep the dst cache when uncloning an skb dst and its metadata
Quoting Paolo Abeni (2022-02-02 15:24:51)
> On Wed, 2022-02-02 at 12:01 +0100, Antoine Tenart wrote:
> > memcpy(&new_md->u.tun_info, &md_dst->u.tun_info,
> > sizeof(struct ip_tunnel_info) + md_size);
> > +#ifdef CONFIG_DST_CACHE
> > + ret = dst_cache_init(&new_md->u.tun_info.dst_cache, GFP_ATOMIC);
> > + if (ret) {
> > + /* We can't call metadata_dst_free directly as the still shared
> > + * dst cache would be released.
> > + */
> > + kfree(new_md);
>
> I think here you can use metadata_dst_free(): if dst_cache_init fails,
> the dst_cache will be zeroed.
You're right, I'll use it in v2.
Thanks!
Antoine
Powered by blists - more mailing lists