netdev - Re: [PATCH wpan-next v3 1/4] net: ieee802154: ca8210: Fix lifs/sifs periods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f5b23fe2-da5f-aadf-ae26-db6b31b55249@datenfreihafen.org>
Date:   Wed, 2 Feb 2022 18:05:33 +0100
From:   Stefan Schmidt <stefan@...enfreihafen.org>
To:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Alexander Aring <alex.aring@...il.com>,
        linux-wpan@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Xue Liu <liuxuenetmail@...il.com>,
        Marcel Holtmann <marcel@...tmann.org>,
        Harry Morris <harrymorris12@...il.com>,
        David Girault <david.girault@...vo.com>,
        Romuald Despres <romuald.despres@...vo.com>,
        Frederic Blain <frederic.blain@...vo.com>,
        Nicolas Schodet <nico@...fr.eu.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH wpan-next v3 1/4] net: ieee802154: ca8210: Fix lifs/sifs
 periods


Hello.

On 01.02.22 19:06, Miquel Raynal wrote:
> These periods are expressed in time units (microseconds) while 40 and 12
> are the number of symbol durations these periods will last. We need to
> multiply them both with the symbol_duration in order to get these
> values in microseconds.
> 
> Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver")
> Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
> ---
>   drivers/net/ieee802154/ca8210.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
> index f3438d3e104a..2bc730fd260e 100644
> --- a/drivers/net/ieee802154/ca8210.c
> +++ b/drivers/net/ieee802154/ca8210.c
> @@ -2975,8 +2975,8 @@ static void ca8210_hw_setup(struct ieee802154_hw *ca8210_hw)
>   	ca8210_hw->phy->cca.opt = NL802154_CCA_OPT_ENERGY_CARRIER_AND;
>   	ca8210_hw->phy->cca_ed_level = -9800;
>   	ca8210_hw->phy->symbol_duration = 16;
> -	ca8210_hw->phy->lifs_period = 40;
> -	ca8210_hw->phy->sifs_period = 12;
> +	ca8210_hw->phy->lifs_period = 40 * ca8210_hw->phy->symbol_duration;
> +	ca8210_hw->phy->sifs_period = 12 * ca8210_hw->phy->symbol_duration;
>   	ca8210_hw->flags =
>   		IEEE802154_HW_AFILT |
>   		IEEE802154_HW_OMIT_CKSUM |
> 

As mentioned in the discussion on the other thread I ripped this one out 
and applied it as fix to the wpan tree. Thanks!

regards
Stefan Schmidt