lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Feb 2022 09:14:22 -0800 From: Eric Dumazet <edumazet@...gle.com> To: Sebastian Andrzej Siewior <bigeasy@...utronix.de> Cc: bpf <bpf@...r.kernel.org>, netdev <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Jakub Kicinski <kuba@...nel.org>, Jesper Dangaard Brouer <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>, Thomas Gleixner <tglx@...utronix.de> Subject: Re: [PATCH net-next 2/4] net: dev: Remove get_cpu() in netif_rx_internal(). On Wed, Feb 2, 2022 at 4:28 AM Sebastian Andrzej Siewior <bigeasy@...utronix.de> wrote: > > The get_cpu() usage was added in commit > b0e28f1effd1d ("net: netif_rx() must disable preemption") > > because ip_dev_loopback_xmit() invoked netif_rx() with enabled preemtion > causing a warning in smp_processor_id(). The function netif_rx() should > only be invoked from an interrupt context which implies disabled > preemption. The commit > e30b38c298b55 ("ip: Fix ip_dev_loopback_xmit()") > > was addressing this and replaced netif_rx() with in netif_rx_ni() in > ip_dev_loopback_xmit(). > > Based on the discussion on the list, the former patch (b0e28f1effd1d) > should not have been applied only the latter (e30b38c298b55). > > Remove get_cpu() since the function is supossed to be invoked from > context with stable per-CPU pointers (either by disabling preemption or > software interrupts). > > Link: https://lkml.kernel.org/r/20100415.013347.98375530.davem@davemloft.net > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de> > --- Reviewed-by: Eric Dumazet <edumazet@...gle.com> Thanks !
Powered by blists - more mailing lists