netdev - Re: [net-next PATCH v8 07/16] net: dsa: tag_qca: add define for handling MIB packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Feb 2022 18:56:24 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Ansuel Smith <ansuelsmth@...il.com>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [net-next PATCH v8 07/16] net: dsa: tag_qca: add define for
 handling MIB packet



On 2/1/2022 4:03 PM, Ansuel Smith wrote:
> Add struct to correctly parse a mib Ethernet packet.
> 
> Signed-off-by: Ansuel Smith <ansuelsmth@...il.com>
> ---
>   include/linux/dsa/tag_qca.h | 10 ++++++++++
>   net/dsa/tag_qca.c           |  4 ++++
>   2 files changed, 14 insertions(+)
> 
> diff --git a/include/linux/dsa/tag_qca.h b/include/linux/dsa/tag_qca.h
> index f366422ab7a0..1fff57f2937b 100644
> --- a/include/linux/dsa/tag_qca.h
> +++ b/include/linux/dsa/tag_qca.h
> @@ -62,4 +62,14 @@ struct qca_mgmt_ethhdr {
>   	__be16 hdr;		/* qca hdr */
>   } __packed;
>   
> +enum mdio_cmd {
> +	MDIO_WRITE = 0x0,
> +	MDIO_READ
> +};
> +
> +struct mib_ethhdr {
> +	u32 data[3];		/* first 3 mib counter */
> +	__be16 hdr;		/* qca hdr */
> +} __packed;

For consistency with patch 7, you might want to name this structure 
qca_mib_ethhdr?

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian