netdev - Re: [PATCH] rtlwifi: remove redundant initialization of variable ul

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Feb 2022 08:02:30 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Pkshih <pkshih@...ltek.com>
Cc:     "kvalo@...nel.org" <kvalo@...nel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "colin.i.king@...il.com" <colin.i.king@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtlwifi: remove redundant initialization of variable
 ul_encalgo

On Mon, Jan 31, 2022 at 02:53:40AM +0000, Pkshih wrote:
> On Sun, 2022-01-30 at 22:37 +0000, Colin Ian King wrote:
> 
> When I check this patch, I find there is no 'break' for default case.
> Do we need one? like
> 
> @@ -226,6 +226,7 @@ void rtl_cam_empty_entry(struct ieee80211_hw *hw, u8 uc_index)
>                 break;
>         default:
>                 ul_encalgo = rtlpriv->cfg->maps[SEC_CAM_AES];
> +               break;

No, it's not necessary.  The choice of style is up to the original
developer.

regards,
dan carpenter