netdev - Re: [PATCH net-next 4/4] net: dsa: mv88e6xxx: improve 88e6352 serdes statistics detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YfveduCCD+n8vf1g@lunn.ch>
Date:   Thu, 3 Feb 2022 14:53:58 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc:     Vivien Didelot <vivien.didelot@...il.com>,
        Marek Beh__n <kabel@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 4/4] net: dsa: mv88e6xxx: improve 88e6352 serdes
 statistics detection

On Thu, Feb 03, 2022 at 01:30:52PM +0000, Russell King (Oracle) wrote:
> The decision whether to report serdes statistics currently depends on
> the cached C_Mode value for the port, read at probe time or updated by
> configuration. However, port 4 can be in "automedia" mode when it is
> used as a serdes port, meaning it switches between the internal PHY and
> the serdes, changing the read-only C_Mode value depending on which
> first gains link. Consequently, the C_Mode value read at probe does not
> accurately reflect whether the port has the serdes associated with it.
> 
> In "net: dsa: mv88e6xxx: add mv88e6352_g2_scratch_port_has_serdes()",
> we added a way to read the hardware configuration to determine which
> port has the serdes associated with it. Use this to determine which
> port reports the serdes statistics.
> 
> Reviewed-by: Marek Behún <kabel@...nel.org>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew