netdev - Re: [PATCH] arm64: dts: qcom: add IPA qcom,qmp property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Feb 2022 08:44:47 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Alex Elder <elder@...aro.org>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        "Gross, Andy" <agross@...nel.org>,
        David Miller <davem@...emloft.net>,
        Matthias Kaehlcke <mka@...omium.org>,
        Evan Green <evgreen@...omium.org>, cpratapa@...eaurora.org,
        avuyyuru@...eaurora.org, jponduru@...eaurora.org,
        subashab@...eaurora.org, Alex Elder <elder@...nel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: add IPA qcom,qmp property

On Thu, Feb 3, 2022 at 5:27 AM Alex Elder <elder@...aro.org> wrote:
>
> On 2/2/22 11:06 PM, Jakub Kicinski wrote:
> > On Tue,  1 Feb 2022 08:07:23 -0600 Alex Elder wrote:
> >> At least three platforms require the "qcom,qmp" property to be
> >> specified, so the IPA driver can request register retention across
> >> power collapse.  Update DTS files accordingly.
> >>
> >> Signed-off-by: Alex Elder <elder@...aro.org>
> >> ---
> >>
> >> Dave, Jakub, please let Bjorn take this through the Qualcomm tree.
> >
> > I don't know much about DT but the patch defining the property is
> > targeting net - will it not cause validation errors? Or Bjorn knows
> > to wait for the fixes to propagate? Or it doesn't matter? :)
>
> It might matter sometimes, but in this case it does not.
>
> If the DT property is present but never referenced by the
> code, it doesn't matter.
>
> The code in this patch looks up the DT property, and its
> behavior is affected by whether the property is there
> or not.  If it's not there, it's treated as an error
> that can be safely ignored.
>
> In the case this fix is actually needed, we'll need
> both the code present and DT property defined.  If
> the code is there but not the property, it's OK, but
> the bug won't be fixed quite yet.

If there's only one possible node that qcom,qmp points to, you can
just get the node by its compatible (of_find_compatible_node()). Then
you don't need a DT update to make things work. Of course, this
doesn't work too well if there are 10 possible compatibles without a
common fallback compatible.

Rob