lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 3 Feb 2022 11:39:24 -0800 From: Jakub Kicinski <kuba@...nel.org> To: Sebastian Andrzej Siewior <bigeasy@...utronix.de> Cc: bpf@...r.kernel.org, netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Eric Dumazet <edumazet@...gle.com>, Jesper Dangaard Brouer <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>, Thomas Gleixner <tglx@...utronix.de> Subject: Re: [PATCH net-next v2 4/4] net: dev: Make rps_lock() disable interrupts. On Thu, 3 Feb 2022 17:41:30 +0100 Sebastian Andrzej Siewior wrote: > > I think you can re-jig this a little more - rps_ipi_queued() only return > > 0 if sd is "local" so maybe we can call __napi_schedule_irqoff() > > instead which already has the if () for PREEMPT_RT? > > > > Maybe moving the ____napi_schedule() into rps_ipi_queued() and > > renaming it to napi_schedule_backlog() or napi_schedule_rps() > > would make the code easier to follow in that case? > > Something like this then? Exactly!
Powered by blists - more mailing lists