netdev - Re: [PATCH net-next] net: don't include ndisc.h from ipv6.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17bcd4cf0b983578325715f89d98c3e3f85c5a4e.camel@codeconstruct.com.au>
Date:   Thu, 03 Feb 2022 12:53:48 +0800
From:   Jeremy Kerr <jk@...econstruct.com.au>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, j.vosburgh@...il.com, vfalico@...il.com,
        andy@...yhouse.net, oliver@...kum.org, yoshfuji@...ux-ipv6.org,
        dsahern@...nel.org, alex.aring@...il.com,
        jukka.rissanen@...ux.intel.com, stefan@...enfreihafen.org,
        matt@...econstruct.com.au, linux-usb@...r.kernel.org,
        linux-bluetooth@...r.kernel.org, linux-wpan@...r.kernel.org
Subject: Re: [PATCH net-next] net: don't include ndisc.h from ipv6.h

Hi Jakub,

> Nothing in ipv6.h needs ndisc.h, drop it.

Looks good, we lose the ARPHRD definitions without ndisc.h, but your
change to add if_arp.h addresses that:

> --- a/net/mctp/device.c
> +++ b/net/mctp/device.c
> @@ -6,6 +6,7 @@
>   * Copyright (c) 2021 Google
>   */
>  
> +#include <linux/if_arp.h>
>  #include <linux/if_link.h>
>  #include <linux/mctp.h>
>  #include <linux/netdevice.h>

So, for the net/mctp part:

Acked-by: Jeremy Kerr <jk@...econstruct.com.au>

Cheers,


Jeremy