netdev - Re: [PATCH libnetfilter_queue] libnetfilter_queue: add support of skb->priority

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Feb 2022 15:20:44 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Florian Westphal <fw@...len.de>
Cc:     Nicolas Dichtel <nicolas.dichtel@...nd.com>,
        netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH libnetfilter_queue] libnetfilter_queue: add support of
 skb->priority

On Fri, Feb 04, 2022 at 01:01:26PM +0100, Florian Westphal wrote:
> Nicolas Dichtel <nicolas.dichtel@...nd.com> wrote:
> > 
> > Le 04/02/2022 à 11:26, Nicolas Dichtel a écrit :
> > > Available since linux v5.18.
> > > 
> > > Link: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=
> > > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> > > ---
> > 
> > Should I send another patch for the 'set' part?
> > In this case, a nfq_set_verdict3(). The name is a bit ugly ;-)
> > Any suggestions?
> 
> I think we should just let the old api die and tell users
> to use the mnl interface, that allows to add the new attribute
> as soon as its available.

We have to provide a simple API based on mnl which ressembles the
existing old API.

Feedback in these years is that there are a users that do not need to
know about netlink details / advanced handling.