netdev - Re: [PATCH iproute2-next] mptcp: add the fullmesh flag setting support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220204101734.1a560400@hermes.local>
Date:   Fri, 4 Feb 2022 10:17:34 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Geliang Tang <geliang.tang@...e.com>
Cc:     David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org,
        mptcp@...ts.linux.dev, Paolo Abeni <pabeni@...hat.com>,
        Mat Martineau <mathew.j.martineau@...ux.intel.com>
Subject: Re: [PATCH iproute2-next] mptcp: add the fullmesh flag setting
 support

On Fri,  4 Feb 2022 11:29:03 +0800
Geliang Tang <geliang.tang@...e.com> wrote:

> This patch added the fullmesh flag setting support, use it like this:
> 
>  ip mptcp endpoint change id 1 fullmesh
>  ip mptcp endpoint change id 1 nofullmesh
>  ip mptcp endpoint change id 1 backup fullmesh
>  ip mptcp endpoint change id 1 nobackup nofullmesh
> 
> Add the fullmesh flag check for the adding address, the fullmesh flag
> can't be used with the signal flag in that case.
> 
> Update the port keyword check for the setting flags, allow to use the
> port keyword with the non-signal flags. Don't allow to use the port
> keyword with the id number.
> 
> Update the usage of 'ip mptcp endpoint change', it can be used in two
> forms, using the address directly or the id number of the address:
> 
>  ip mptcp endpoint change id 1 fullmesh
>  ip mptcp endpoint change 10.0.2.1 fullmesh
>  ip mptcp endpoint change 10.0.2.1 port 10100 fullmesh
> 
> Acked-by: Paolo Abeni <pabeni@...hat.com>
> Acked-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>
> Signed-off-by: Geliang Tang <geliang.tang@...e.com>

I don't see  any parts in here to show the flag settings?